Add some explicit integer64 support #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R/num_equal.R
Outdated
| attributes(x) <- NULL | ||
| attributes(y) <- NULL | ||
| if (is_int64(x) || is_int64(y)) { | ||
| x <- bit64::as.integer64(x) |
There was a problem hiding this comment.
one concern here is trying to compare numbers from the nonoverlapping domains of int64 and double (forget the exact values off the top of my head)
i.e. an integer without exact representation as double vs a double too large for integer64
There was a problem hiding this comment.
Ooh yeah, good thought. 36893488147419103232 is an integer (2^65) that's you can represent with a double, but not in int64. But of course not all integers bigger than that can be represented, e.g. 36893488147419103232 + 1 == 36893488147419103232 is TRUE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159
@MichaelChirico does this make sense to you?